mozilla / tippy-top-sites-deprecated

[deprecated][unmaintained]
6 stars 7 forks source link

Add better professional sportsball icons #46

Open pdehaan opened 7 years ago

pdehaan commented 7 years ago

Currently we have [desktop] mlb.com in tippy-top-sites, but I noticed that somehow I had a mobile m.mlb.com link in my history and the favicon was terrible.

new_tab

We should probably add another entry in topsites for http://m.mlb.com/ and use the same icon and everything else (so it will only increase the JSON payload by about 150 characters (since we'll recycle the same image, etc).

favicon_ico__icon_image__16 x 16_pixels_

http://m.mlb.com/favicon.ico


Desktop vs Mobile:

window_and_new_tab

pdehaan commented 7 years ago

Actually, m.mlb.com, wnba.com, or oddly nba.com won't win any awards either...

window_and_new_tab

Not sure why nba.com isn't prettier. It should be in the ... Nevermind. Only MLB is in the tippy-top-sites, not NBA, NFL, NHL, or WNBA.

pdehaan commented 7 years ago

Thankfully, it looks like the metadata proxy server returns some solid results:

`$ http https://embedly-proxy.services.mozilla.com/v2/metadata urls:='["http://www.nba.com","http://www.wnba.com/","http://www.nfl.com/","http://www.nhl.com"]' -j` ``` sh HTTP/1.1 200 OK Connection: keep-alive Content-Length: 1968 Content-Type: application/json Date: Fri, 04 Nov 2016 00:53:29 GMT { "error": "", "urls": { "http://www.nba.com": { "description": "The official site of the National Basketball Association. Includes news, features, multimedia, player profiles, chat transcripts, schedules and statistics.", "favicon_url": "http://i.cdn.turner.com/nba/nba/assets/icons/apple-touch-icon.png", "images": [], "original_url": "http://www.nba.com", "provider_name": "nba", "title": "NBA.com", "url": "http://www.nba.com" }, "http://www.nfl.com/": { "description": "The official source for NFL news, video highlights, fantasy football, game-day coverage, schedules, stats, scores and more.", "favicon_url": "http://i.nflcdn.com/static/site/7.4/img/apple/apple-touch-icon-57x57.png", "images": [ { "height": 630, "url": "http://i.nflcdn.com/static/content/public/static/img/share/shield.jpg", "width": 1200 } ], "original_url": "http://www.nfl.com/", "provider_name": "nfl", "title": "NFL.com - Official Site of the National Football League", "url": "http://www.nfl.com/" }, "http://www.nhl.com": { "description": "The official National Hockey League website including news, rosters, stats, schedules, teams, and video.", "favicon_url": "http://www-league.nhlstatic.com/builds/site-core/df9488943d10a2f8ee1599b5190c7c84e8b21fb6_1478183431/images/iOS/apple-icon-57x57.png", "images": [ { "height": 630, "url": "https://nhl.bamcontent.com/images/logos/league/1200x630_NHL.com_FB.JPG", "width": 1200 } ], "original_url": "http://www.nhl.com", "provider_name": "nhl", "title": "Official Site of the National Hockey League", "url": "https://www.nhl.com" }, "http://www.wnba.com/": { "description": "Official site of the WNBA with news, scores, schedule, information about players and coaches, statistics, tickets, merchandise.", "favicon_url": "http://ak-static.cms.nba.com/wp-content/themes/wnba-parent/img/favicon.ico", "images": [], "original_url": "http://www.wnba.com/", "provider_name": "wnba", "title": "WNBA.com - Official Site of the WNBA", "url": "http://www.wnba.com/" } } } ```

Figure 1: http://www.nba.com/

Figure 2: http://www.nfl.com/

Figure 3: http://www.nhl.com/

Figure 4: http://www.wnba.com/ -- OK, this one still not very good.