mozilla / tippy-top-sites-deprecated

[deprecated][unmaintained]
7 stars 7 forks source link

fix return value of getSiteData() #49

Closed rlr closed 7 years ago

rlr commented 7 years ago

r? @pdehaan

pdehaan commented 7 years ago

r+

pdehaan commented 7 years ago

Not sure if we want to republish to npm. The key difference seems to be now if we pass an non-matching domain, we get an empty object back. The old behavior was we'd get undefined back (which could cause errors if we try and access a property of the undefined object).

rlr commented 7 years ago

Yep, we should publish update to npm. I'll do it once I get the repo powers I need.

k88hudson commented 7 years ago

I can publish, let's ping someone about repo access

rlr commented 7 years ago

thank you! @k88hudson