mozilla / tippy-top-sites-deprecated

[deprecated][unmaintained]
6 stars 7 forks source link

Add Bugzilla icon? #54

Open pdehaan opened 7 years ago

pdehaan commented 7 years ago

Not sure what we're doing anymore...

Should we be adding semi-niche icons? Currently a lot of our properties look pretty bad (bugzilla, hello, etc).

Currently it seems like https://bugzilla.mozilla.org has an honestly pretty bad favicon: https://bugzilla.mozilla.org/extensions/BMO/web/images/favicon.ico

They also have this, which helps for Activity Stream highlights, but not favicons:

<meta property="og:image" content="https://bugzilla.mozilla.org/extensions/OpenGraph/web/bugzilla.png">

For reasons I'm not sure of (unless Activity Stream ignores favicons under 32px), Activity Stream isn't showing that favicon, and reverts back to just "B" letter as a placeholder:

new_tab


$ http https://embedly-proxy.services.mozilla.com/v2/metadata urls:='["https://bugzilla.mozilla.org"]' -j
HTTP/1.1 200 OK
Connection: keep-alive
Content-Length: 418
Content-Type: application/json
Date: Tue, 15 Nov 2016 18:53:06 GMT

{
    "error": "",
    "urls": {
        "https://bugzilla.mozilla.org": {
            "favicon_url": "https://bugzilla.mozilla.org/extensions/BMO/web/images/favicon.ico",
            "images": [
                {
                    "height": 200,
                    "url": "https://bugzilla.mozilla.org/extensions/OpenGraph/web/bugzilla.png",
                    "width": 200
                }
            ],
            "original_url": "https://bugzilla.mozilla.org",
            "provider_name": "bugzilla mozilla",
            "title": "Bugzilla Main Page",
            "url": "https://bugzilla.mozilla.org/"
        }
    }
}
pdehaan commented 7 years ago

Not sure if we should:

(a) bloat the tippy-top-sites (b) try and file all these upstream so Bugzilla can add more OpenGraph tags

/cc @k88hudson @jaredkerim

-- Also note that the Hello link (https://hello.firefox.com/NVA3p39CffA) doesn't display an icon in the screenshot above. But I think that page just redirects to a "Support for Hello discontinued in Firefox 49" page, so I guess that's not really an issue anymore.

pdehaan commented 7 years ago

try and file all these upstream so Bugzilla can add more OpenGraph tags

Filed upstream as https://bugzilla.mozilla.org/show_bug.cgi?id=1317765 🐟