mozilla / tippy-top-sites-deprecated

[deprecated][unmaintained]
6 stars 7 forks source link

Add larger images for a few sites #65

Closed pdehaan closed 7 years ago

pdehaan commented 7 years ago

Steps to reproduce:

  1. Run npm test in this repo.

Actual results:

Six sites don't seem to have the higher-res assets:

  1. dailymail
  2. dailybeast
  3. images.google
  4. jcpenney
  5. verizonwireless
  6. wikia
  1563 passing (481ms)
  6 failing

  1) images/ should have an image with the correct width and height for dailymail:
     AssertionError: width: expected 64 to equal 128
      at Context.it (test/image-sizes.test.js:46:14)

  2) images/ should have an image with the correct width and height for dailybeast:
     AssertionError: width: expected 64 to equal 128
      at Context.it (test/image-sizes.test.js:46:14)

  3) images/ should have an image with the correct width and height for images.google:
     AssertionError: width: expected 64 to equal 128
      at Context.it (test/image-sizes.test.js:46:14)

  4) images/ should have an image with the correct width and height for jcpenney:
     AssertionError: width: expected 64 to equal 128
      at Context.it (test/image-sizes.test.js:46:14)

  5) images/ should have an image with the correct width and height for verizonwireless:
     AssertionError: width: expected 106 to equal 128
      at Context.it (test/image-sizes.test.js:46:14)

  6) images/ should have an image with the correct width and height for wikia:
     AssertionError: width: expected 64 to equal 128
      at Context.it (test/image-sizes.test.js:46:14)
pdehaan commented 7 years ago

npm test works locally vs master. Me thinks we already did this.