search

mozilla / tippy-top-sites-deprecated

[deprecated][unmaintained]
6 stars 7 forks source link

Add international TLD for amazon, ebay, bbc #74

Closed rlr closed 7 years ago

rlr commented 7 years ago

r? @pdehaan

pdehaan commented 7 years ago

@rlr Sorry, totally missed this in my GitHub inbox... Looks good. A few nits, but you're fine to merge with or without them. I think I have a bit-rotting PR for smile.amazon.com, which can be killed (or rebased, depending on whom makes the change).

pdehaan commented 7 years ago

Semi-related, but not sure how far we want to go down the rabbit hole. Apparently there are sites like https://www.airbnb.ca/ and https://www.americanexpress.ca/ (although the latter redirects to .com/canada portal).

PROS: Adding a bunch of locale aliases is cheap and doesn't notably increase bundle size. CONS: It's boring and tedious to go through each result trying to find country specific URLs.

rlr commented 7 years ago

No worries! I'll make those changes. Thanks!