mozilla / webmaker-core

React-based core for Webmaker shared across all platforms
https://foundation.mozilla.org/en/artifacts/webmaker/
Mozilla Public License 2.0
64 stars 39 forks source link

UI for page background color #782

Closed xmatthewx closed 8 years ago

xmatthewx commented 8 years ago

Let's consider an approach that utilizes an element-editor-like view. Unique UI for this one feature is too heavy of a lift.

This view could include our typical color picker and maybe later an option to set a background image.

see: #63

xmatthewx commented 8 years ago

This could be accessed via an icon on either the page editor or the project editor (if we still have a selected page state). Wherever it fits more super chilly.

vazquez commented 8 years ago

Design Annotation

change background page colour

xmatthewx commented 8 years ago

Implementation notes:

alanmoo commented 8 years ago

@vazquez Is that paint fill icon already in the repo somewhere?

xmatthewx commented 8 years ago

I don't love this paint bucket. It's a bit hard to read.

alanmoo commented 8 years ago

As I'm building this I'm simply using the paint brush as a placeholder. Do we keep that for consistency?

vazquez commented 8 years ago

The paint brush can be a good alternative since we removed the paint brush in all other views in favour of the pencil.

vazquez commented 8 years ago

@xmatthewx We can also try

screenshot 2015-12-01 11 15 24

or

screenshot 2015-12-01 11 15 43

xmatthewx commented 8 years ago

I like the palette.

If we use the paintbrush, let's adjust it so it looks less like the pencil. Current, both point down from top-right to bottom-left. They don't have enough contrast. Brush could be oriented like the wand above, with brush upward.

vazquez commented 8 years ago

I think I like the palette better.

screenshot 2015-12-01 15 03 03

screenshot 2015-12-01 15 03 35

Palette icon (with svgo optimization): https://dl.dropboxusercontent.com/u/43783651/Mozilla/Android/palette-icon.svg

xmatthewx commented 8 years ago

R+ on the palette

alanmoo commented 8 years ago

@vazquez Default color options? Normal set with transparent replaced by that dark one in the comps? If so, what is that one color?

xmatthewx commented 8 years ago

Dark one is probably the same as text color on text element.

Wondering: should we swap the blue for the yellow. If page background often match the app header, things might get a bit weird.

alanmoo commented 8 years ago

Yeah I was wondering if we should have a different palette altogether. I'm not sure how often the default colors get used for elements vs tinkered ones, but new colors here that complement the default element ones could result in more good looking projects.

vazquez commented 8 years ago

Let's have these colours:

screenshot 2015-12-02 14 48 35

We have a blackish colour, a greyish colour, and some colours that are complementary with a blue header.

New Colour Values:

alanmoo commented 8 years ago

Transparent vs white? Thoughts?

vazquez commented 8 years ago

I don't have a strong preference. @xmatthewx what do you think? How should we communicate "white" in this case?

xmatthewx commented 8 years ago

Good point. White is probably better. (I bet most people read that as none, not transparent. But still, white requires less thinking.)

alanmoo commented 8 years ago

Turns out it's not actually white, but an off-white #f2f6fc. After a quick in person discussion (!), @xmatthewx and I decided we should use that instead of #FFF in the palette.