mozilla / webmaker-core

React-based core for Webmaker shared across all platforms
https://foundation.mozilla.org/en/artifacts/webmaker/
Mozilla Public License 2.0
64 stars 39 forks source link

Add an icon to buttons that link to URL #791

Closed xmatthewx closed 8 years ago

xmatthewx commented 8 years ago

Some buttons will pan to another page, while others leave the app and open the browser. Wondering if we should add an icon or other indicator to buttons that exit the app.

vazquez commented 8 years ago

In Android-land, there are two icons within its visual language that indicate to the user they are leaving the app, or opening something within the app:

screenshot 2015-11-13 16 06 19

and

screenshot 2015-11-13 16 08 40

ps. We would remove the button icon if we add an icon to buttons that link to a URL.

xmatthewx commented 8 years ago

:+1: just a matter of seeing how this balances with centered text. maybe matches colors of button label but with half opacity? make a pile of options.

vazquez commented 8 years ago

What are you thinking @xmatthewx? I like the third option from the top.

screenshot 2015-11-16 14 10 08
vazquez commented 8 years ago

For context:

play page view

xmatthewx commented 8 years ago

Yep. Icon within the button looks good. Wondering if some opacity would be nice. Your call.

vazquez commented 8 years ago

Yes, yes I like that.

xmatthewx commented 8 years ago

:+1: prep some annotation and then assign to @gvn

vazquez commented 8 years ago

Design Annotation

url buttons annotations

vazquez commented 8 years ago

Tracking implementation in #797