mozilla / webmaker-core

React-based core for Webmaker shared across all platforms
https://foundation.mozilla.org/en/artifacts/webmaker/
Mozilla Public License 2.0
64 stars 39 forks source link

Images Options show NaN and undefinedpx values #813

Closed vazquez closed 8 years ago

vazquez commented 8 years ago

STR:

When entering the Image Options view, this is what you see:

Issues Found

  1. View is broken, you can scroll left and right
  2. Opacity value shows as NaN%
  3. Border width shows as undefinedpx

screenshot_20151118-134547

xmatthewx commented 8 years ago

Uh oh. cc @gvn @alanmoo

alanmoo commented 8 years ago

I noticed this when working on #799, so if that gets merged in it should fix this. For some reason, the value attribute was missing on those sliders.

https://github.com/mozilla/webmaker-core/pull/799/files#diff-e858a41c1876cbd4433de2314fa2172dR55

xmatthewx commented 8 years ago

So we'll need to make sure that we add #799 to Beta and test, before we go to production.

xmatthewx commented 8 years ago

resolved

ioana-chiorean commented 8 years ago

:tada: :dancer: