search

mozilla / webmaker-core

React-based core for Webmaker shared across all platforms
https://foundation.mozilla.org/en/artifacts/webmaker/
Mozilla Public License 2.0
65 stars 39 forks source link

adding descriptions #903

Closed gvn closed 8 years ago

gvn commented 8 years ago

Closes #794

alanmoo commented 8 years ago

Descriptions aren't deployed to the staging API yet, right?

xmatthewx commented 8 years ago

Should be there on staging. https://github.com/mozilla/api.webmaker.org/commit/6cba731c9a3807712d14b0dcdff41718975fb74b

alanmoo commented 8 years ago

Hmmm...Maybe I did something wrong while testing this, I'll try again.

alanmoo commented 8 years ago

Two things I noticed:

When adding/changing a description, going back to the make view does not reflect the change until you manually pull to reload.

When adding a description, there seems to be an issue with saving after the description has been too long. Even after reducing down to a reasonable length, backing out of the view results in the description not saving.

Also take a look at the effect of empty descriptions on the layout of cards, as I mentioned earlier today.

gvn commented 8 years ago

I think everything should be working now aside from the whole Make view not updating thing.