search

mozilla / webmaker-core

React-based core for Webmaker shared across all platforms
https://foundation.mozilla.org/en/artifacts/webmaker/
Mozilla Public License 2.0
64 stars 39 forks source link

Improve project sharing copy #946

Open xmatthewx opened 8 years ago

xmatthewx commented 8 years ago

When a user shares a project, Webmaker sends out

Check out this project on Webmaker! https://....

The share would be more inspiring and links more likely to be followed if we used the project title. Most mainstream platforms don't name themselves in their shares.

Proposed: Check out TITLE by USERNAME.

This is executed in webmaker-android /util/Share.java.

xmatthewx commented 8 years ago

opinions @vazquez on this?

Proposed: Check out TITLE by USERNAME.

ryanwarsaw commented 8 years ago

@vazquez update?

xmatthewx commented 8 years ago

You can just run with the proposed change @ryanw-se. Thanks!

ryanwarsaw commented 8 years ago

@xmatthewx I looked into doing a hyperlink but I don't think that will work very well since some apps don't support it, instead I opted-in for "Check out <title> by <username>. <link>"

xmatthewx commented 8 years ago

Yep. That makes sense. That's what I was thinking but didn't make clear. URL at the end.

ryanwarsaw commented 8 years ago

Quick update on this, I did start work on this a few weeks back but got blocked because of my limited knowledge on how we send data to the backend on this (webmaker-core). I plan to do a bit more research on this soon and knock this out.

Dev note: From preliminary testing, I've determined the easiest way to do this would be to utilize the Memory Storage API, however this is only temporary until we switch over to the Queue based system.