search

mozilla / webmaker-core

React-based core for Webmaker shared across all platforms
https://foundation.mozilla.org/en/artifacts/webmaker/
Mozilla Public License 2.0
64 stars 39 forks source link

adding tags to cards #949

Closed gvn closed 8 years ago

gvn commented 8 years ago

Related to #795 Requires https://github.com/mozilla/webmaker-android/pull/2455

alanmoo commented 8 years ago

giphy

alanmoo commented 8 years ago

My only thought is that we might want descriptions to show up on cards in tag filters, but that's easy enough to change. Maybe @xmatthewx has thoughts on that.

xmatthewx commented 8 years ago

If I understand you correctly, yes. Cards in the tag list view would ideally appear the same as they do in discover, with title, avatar, and description.

gvn commented 8 years ago

I left descriptions out because they weren't in the comp, but I can add them back in...

@vazquez thoughts?

vazquez commented 8 years ago

@gvn Yes, let's add them in. Sorry for not adding descriptions in the comp.

gvn commented 8 years ago

No worries!

alanmoo commented 8 years ago

R+ again

vazquez commented 8 years ago

Right on, starting design testing now