search

mr54ndm4n / Groot

Just a CSV Util Package! keep it simple, let's groot do it for you!
https://www.nuget.org/packages/Groot/1.0.0#
Apache License 2.0
2 stars 5 forks source link

Discussion: Is there any idea to improve `groot`? #15

Open mr54ndm4n opened 6 years ago

mr54ndm4n commented 6 years ago

Can be any features, design, etc. so we can create a new issues :)

avivbiton commented 6 years ago

I'd say refactoring is really needed, naming and break code into smaller methods, it's hard to understand what each method does ( For me at least)

avivbiton commented 6 years ago

From looking more at the code, what I feel that is missing: Error handling, what happens when the Csv File is invalid?
Should the program throw an exception with the invalid line number or just skip the line? A configuration file should be used for that.