search

mrash / fwknop

Single Packet Authorization > Port Knocking
http://www.cipherdyne.org/fwknop/
GNU General Public License v2.0
1.1k stars 229 forks source link

DEF_RUN_DIR uses localstatedir instead of runstatedir #293

Open fmarier opened 5 years ago

fmarier commented 5 years ago

DEF_RUN_DIR is defined based on SYSRUNDIR which is itself set to localstatedir.

In the Debian package, I've set this to /run but it does look strange to set --localstatedir when there is also a --runstatedir configure variable:

--localstatedir=DIR     modifiable single-machine data [PREFIX/var]
--runstatedir=DIR       modifiable per-process data [LOCALSTATEDIR/run]

It doesn't look like runstatedir is used anywhere and so it doesn't matter that it ends up being set to a non-sensical value (/run/run), but perhaps DEF_RUN_DIR should use that instead of localstatedir?

mrash commented 5 years ago

Hi - can you send a pull request for this one? Not sure if I have it correct. I'm assuming server/fwknopd_common.h needs to be modified at line 72.

fmarier commented 5 years ago

I've just created #300 and tested it in the Debian package.