search

mrash / fwknop

Single Packet Authorization > Port Knocking
http://www.cipherdyne.org/fwknop/
GNU General Public License v2.0
1.1k stars 229 forks source link

Fix compilation with -fno-common (the default in gcc-10+) #306

Closed hlein closed 4 years ago

hlein commented 4 years ago

Tested with gcc-8 and gcc-9 with CFLAGS="-fno-common" using:

./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --docdir=/usr/share/doc/fwknop-2.6.10 --htmldir=/usr/share/doc/fwknop-2.6.10/html --with-sysroot=/ --libdir=/usr/lib64 --localstatedir=/run --enable-client --enable-file-cache --disable-nfq-capture --enable-server --disable-udp-server --without-gpgme --with-iptables=/sbin/iptables

It is possible that other fwknop configure-time options would trigger additional -fno-common errors that I have not seen yet.

Closes: https://github.com/mrash/fwknop/issues/305 Signed-off-by: Hank Leininger hlein@korelogic.com

Jakuje commented 4 years ago

I would just drop the name as shown in [1]. It is not used anywhere.

[1] https://github.com/Jakuje/fwknop/commit/a87325b0816a79329cf0b4d4f9ebf247ead117db

hlein commented 4 years ago

I would just drop the name as shown in [1]. It is not used anywhere.

Ah, good call, I did not look closely enough to be sure it wasn't used.

hlein commented 4 years ago

Simpler to just use @Jakuje 's fix, closing this.