damienstuart
commented
7 months ago The version of autoconf via Homebrew on Mac is version 2.72. Based on some intial research, that version has changes that appear to be less forgiving when it come to AS_IF macros and quoting. I found this info at https://developers.redhat.com/blog/2023/02/23/autoconf-272-broke-my-build-how-do-i-fix-it.
I found that the last AS_IF in a set of nested AS_IF macros for handling the forcing a specific firewall exe was missing its third (else) argument. Adding the empty argument ([]) fixes this error. Here is the diff for that change (on the current configure.ac from the master branch. Also note that I did not run autoupdate on this):
diff --git a/configure.ac b/configure.ac index 2a12f1fb..0bd432ae 100644 --- a/configure.ac +++ b/configure.ac @@ -757,7 +757,7 @@ dnl IPFW_EXE="" IPTABLES_EXE="" FIREWALLD_EXE=""
- ]
- ], [] ] ] ]
That should address the syntax error.
Now, if you do run autoupdate on a Mac with the latest autoconf from Homebrew, it will set AC_PREREQ to version 2.72 - which has not be released to many other platforms (i.e. latest Fedora). I recommend you set that back to version 2.62. The other updates are probably ok, and you can remove the items that are tagged as obsolete.
Regards,
-Damien
On 1/22/24 5:42 PM, e40 @.***> wrote:
It would be nice to get some tips on how to move forward. This is my attempt to get the project moving forward again. Thanks.
|./configure: line 18861: syntax error near unexpected token
;;' ./configure: line 18861:;;' |This is after me running |autoconf| and then |configure|.
I've updated Homebrew. The full configure output is below.
Here's the |git diff| output for what |autoconf| changed:
|diff --git a/configure.ac b/configure.ac index 2a12f1fb..1787c3d5 100644 --- a/configure.ac +++ b/configure.ac @@ -7,14 +7,14 @@ dnl Inspiration from RRDtool configure.ac, the AutoConf Archive dnl (http://www.nongnu.org/autoconf-archive/), and other examples. dnl Minimum Autoconf version required. -AC_PREREQ(2.62) +AC_PREREQ([2.72]) dnl Define our name, version and email. m4_define(my_package, [fwknop]) m4_define(my_version, [2.6.11]) m4_define(my_bug_email, @.***) -AC_INIT(my_package, my_version, my_bug_email) +AC_INIT([my_package],[my_version],[my_bug_email]) AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_AUX_DIR(config) @@ -107,7 +107,7 @@ int main(void){char x[[256]]; snprintf(x, sizeof(x), "NNN"); return 0;} LDFLAGS="$saved_LDFLAGS"] )])dnl -AC_GNU_SOURCE +AC_USE_SYSTEM_EXTENSIONS AC_PROG_CC AM_PROG_CC_C_O @@ -118,7 +118,7 @@ AC_PROG_GREP AC_PROG_INSTALL AC_PROG_LN_S AC_PROG_MAKE_SET -AC_PROG_LIBTOOL +LT_INIT dnl Detect if we are on and Apple platform dnl @@ -365,8 +365,29 @@ fi # Checks for header files. # -AC_HEADER_STDC -AC_HEADER_TIME +m4_warn([obsolete], +[The preprocessor macro 'STDC_HEADERS' is obsolete. + Except in unusual embedded environments, you can safely include all + C89 headers unconditionally.])dnl +# Autoupdate added the next two lines to ensure that your configure +# script's behavior did not change. They are probably safe to remove. +AC_CHECK_INCLUDES_DEFAULT +AC_PROG_EGREP + +m4_warn([obsolete], +[Update your code to rely only on HAVE_SYS_TIME_H, +then remove this warning and the obsolete code below it. +All current systems provide time.h; it need not be checked for. +Not all systems provide sys/time.h, but those that do, all allow +you to include it and time.h simultaneously.])dnl +AC_CHECK_HEADERS_ONCE([sys/time.h]) +# Obsolete code to be removed. +if test $ac_cv_header_sys_time_h = yes; then + AC_DEFINE([TIME_WITH_SYS_TIME],[1],[Define to 1 if you can safely include both <sys/time.h> + and
. This macro is obsolete.]) +fi +# End of obsolete code. + AC_HEADER_RESOLV AC_CHECK_HEADERS([arpa/inet.h ctype.h endian.h errno.h locale.h netdb.h net/ethernet.h netinet/in.h stdint.h stdlib.h string.h strings.h sys/byteorder.h sys/endian.h sys/ethernet.h sys/socket.h sys/stat.h sys/time.h sys/wait.h termios.h time.h unistd.h]) diff --git a/m4/gpgme.m4 b/m4/gpgme.m4 index 44bf43cb..b20962ce 100644 --- a/m4/gpgme.m4 +++ b/m4/gpgme.m4 @@ -12,7 +12,7 @@ AC_DEFUN([_AM_PATH_GPGME_CONFIG], [ AC_ARG_WITH(gpgme-prefix, - AC_HELP_STRING([--with-gpgme-prefix=PFX], + AS_HELP_STRING([--with-gpgme-prefix=PFX], [prefix where GPGME is installed (optional)]), gpgme_config_prefix="$withval", gpgme_config_prefix="") if test "x$gpgme_config_prefix" != x ; then | The full |configure| output:
|$ ./configure checking build system type... aarch64-apple-darwin23.3.0 checking host system type... aarch64-apple-darwin23.3.0 checking target system type... aarch64-apple-darwin23.3.0 checking for a BSD-compatible install... /opt/homebrew/bin/ginstall -c checking whether build environment is sane... yes checking for a race-free mkdir -p... /opt/homebrew/bin/mkdir -p checking for gawk... no checking for mawk... no checking for nawk... no checking for awk... awk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking whether make supports the include directive... yes (GNU style) checking for gcc... gcc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether the compiler supports GNU C... yes checking whether gcc accepts -g... yes checking for gcc option to enable C11 features... none needed checking whether gcc understands -c and -o together... yes checking dependency style of gcc... gcc3 checking for stdio.h... yes checking for stdlib.h... yes checking for string.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for strings.h... yes checking for sys/stat.h... yes checking for sys/types.h... yes checking for unistd.h... yes checking for wchar.h... yes checking for minix/config.h... no checking for sys/time.h... yes checking whether it is safe to define EXTENSIONS... yes checking whether _XOPEN_SOURCE should be defined... no checking for gcc... (cached) gcc checking whether the compiler supports GNU C... (cached) yes checking whether gcc accepts -g... (cached) yes checking for gcc option to enable C11 features... (cached) none needed checking whether gcc understands -c and -o together... (cached) yes checking dependency style of gcc... (cached) gcc3 checking how to run the C preprocessor... gcc -E checking for gawk... (cached) awk checking for a sed that does not truncate output... /opt/homebrew/bin/sed checking for grep that handles long lines and -e... /opt/homebrew/bin/grep checking whether ln -s works... yes checking whether make sets $(MAKE)... (cached) yes checking how to print strings... printf checking for a sed that does not truncate output... (cached) /opt/homebrew/bin/sed checking for egrep... /opt/homebrew/bin/grep -E checking for fgrep... /opt/homebrew/bin/grep -F checking for ld used by gcc... /Library/Developer/CommandLineTools/usr/bin/ld checking if the linker (/Library/Developer/CommandLineTools/usr/bin/ld) is GNU ld... no checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B checking the name lister (/usr/bin/nm -B) interface... BSD nm checking the maximum length of command line arguments... 786432 checking how to convert aarch64-apple-darwin23.3.0 file names to aarch64-apple-darwin23.3.0 format... func_convert_file_noop checking how to convert aarch64-apple-darwin23.3.0 file names to toolchain format... func_convert_file_noop checking for /Library/Developer/CommandLineTools/usr/bin/ld option to reload object files... -r checking for file... file checking for objdump... objdump checking how to recognize dependent libraries... pass_all checking for dlltool... no checking how to associate runtime and link libraries... printf %s\n checking for ar... ar checking for archiver @FILE support... no checking for strip... strip checking for ranlib... ranlib checking command to parse /usr/bin/nm -B output from gcc object... ok checking for sysroot... no checking for a working dd... /opt/homebrew/bin/dd checking how to truncate binary pipes... /opt/homebrew/bin/dd bs=4096 count=1 checking for mt... no checking if : is a manifest tool... no checking for dsymutil... dsymutil checking for nmedit... nmedit checking for lipo... lipo checking for otool... otool checking for otool64... no checking for -single_module linker flag... ld: warning: -single_module is obsolete no checking for -exported_symbols_list linker flag... yes checking for -force_load linker flag... yes checking for dlfcn.h... yes checking for objdir... .libs checking if gcc supports -fno-rtti -fno-exceptions... yes checking for gcc option to produce PIC... -fno-common -DPIC checking if gcc PIC flag -fno-common -DPIC works... yes checking if gcc static flag -static works... no checking if gcc supports -c -o file.o... yes checking if gcc supports -c -o file.o... (cached) yes checking whether the gcc linker (/Library/Developer/CommandLineTools/usr/bin/ld) supports shared libraries... yes checking dynamic linker characteristics... darwin23.3.0 dyld checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking if libtool supports shared libraries... yes checking whether to build shared libraries... yes checking whether to build static libraries... yes checking if gcc supports -Wall -Wformat -Wformat-security... yes checking if gcc supports -fstack-protector-all -fstack-protector... yes checking if gcc supports -fPIE -fPIC... yes checking if gcc supports -pie -fPIC... no checking if gcc supports -D_FORTIFY_SOURCE=2... yes checking if gcc supports -Wl,-z,relro... no checking if gcc supports -Wl,-z,now... no checking for egrep... (cached) /opt/homebrew/bin/grep -E checking for sys/types.h... (cached) yes checking for netinet/in.h... yes checking for arpa/nameser.h... yes checking for netdb.h... yes checking for resolv.h... yes checking for arpa/inet.h... yes checking for ctype.h... yes checking for endian.h... no checking for errno.h... yes checking for locale.h... yes checking for netdb.h... (cached) yes checking for net/ethernet.h... yes checking for netinet/in.h... (cached) yes checking for stdint.h... (cached) yes checking for stdlib.h... (cached) yes checking for string.h... (cached) yes checking for strings.h... (cached) yes checking for sys/byteorder.h... no checking for sys/endian.h... no checking for sys/ethernet.h... no checking for sys/socket.h... yes checking for sys/stat.h... (cached) yes checking for sys/time.h... (cached) yes checking for sys/wait.h... yes checking for termios.h... yes checking for time.h... yes checking for unistd.h... (cached) yes checking for an ANSI C-conforming const... yes checking for int8_t... yes checking for int16_t... yes checking for int32_t... yes checking for int64_t... yes checking for uint8_t... yes checking for uint16_t... yes checking for uint32_t... yes checking for uint64_t... yes checking for off_t... yes checking for pid_t... yes checking for size_t... yes checking for ssize_t... yes checking size of unsigned int... 4 checking whether byte ordering is bigendian... no checking for gcc option to enable large file support... none needed checking for GNU libc compatible malloc... yes checking for GNU libc compatible realloc... yes checking whether lstat correctly handles trailing slash... no checking whether stat accepts an empty string... no checking for bzero... yes checking for fileno... yes checking for gettimeofday... yes checking for memmove... yes checking for memset... yes checking for socket... yes checking for strchr... yes checking for strcspn... yes checking for strdup... yes checking for strncasecmp... yes checking for strndup... yes checking for strrchr... yes checking for strspn... yes checking for strnlen... yes checking for fstat... yes checking for stat... yes checking for lstat... yes checking for chmod... yes checking for chown... yes checking for strlcat... yes checking for strlcpy... yes checking for execvp... yes checking for library containing socket... none required checking for library containing inet_addr... none required checking for gpgme-config... /opt/homebrew/bin/gpgme-config checking for GPGME - version >= 0.4.2... yes checking for gpg... /opt/homebrew/bin/gpg checking for wget... /opt/homebrew/bin/wget ./configure: line 18861: syntax error near unexpected token
;;' ./configure: line 18861:;;' |— Reply to this email directly, view it on GitHub https://github.com/mrash/fwknop/issues/360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRNJBZOSRUH6KVHCQ2CH3YP3TOFAVCNFSM6AAAAABCF7PK46VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TIOJQGE3DCMA. You are receiving this because you are subscribed to this thread.Message ID: @.***>
e40
It would be nice to get some tips on how to move forward. This is my attempt to get the project moving forward again. Thanks.
This is after me running
autoconfand thenconfigure.I've updated Homebrew. The full configure output is below.
Here's the
git diffoutput for whatautoconfchanged:The full
configureoutput: