search

mrash / fwknop

Single Packet Authorization > Port Knocking
http://www.cipherdyne.org/fwknop/
GNU General Public License v2.0
1.09k stars 228 forks source link

Fixes for macOS build #361

Closed e40 closed 7 months ago

e40 commented 7 months ago

Thanks @damienstuart for help with this. It builds and works on macOS 14.3 with up-to-date Homebrew and Xcode.

damienstuart commented 7 months ago

Hi. I recommend you keep the AC_PREREQ value at 2.62. Most other distributions (including the latest Fedora and Ubuntu) have autoconf 2.71 or lower. We want to avoid forcing a newer version of Autoconf that is not available via the normal distributions.

Since AC_PREREQ specifies the minimum required version, please resubmit the pull request with it set at its current value.

Thanks,

-Damien

e40 commented 7 months ago

Hi. I recommend you keep the AC_PREREQ value at 2.62. Most other distributions (including the latest Fedora and Ubuntu) have autoconf 2.71 or lower. We want to avoid forcing a newer version of Autoconf that is not available via the normal distributions.

Since AC_PREREQ specifies the minimum required version, please resubmit the pull request with it set at its current value.

Thanks,

-Damien

Done. Let me know if there's anything else you'd like changed.

Thanks for the help.

e40 commented 7 months ago

@damienstuart should I change the version number or is that only done after a release?

damienstuart commented 7 months ago

No need to change the version. That is typically done just prior to a release.

Get Outlook for iOShttps://aka.ms/o0ukef

From: e40 @.> Sent: Saturday, January 27, 2024 3:15:20 PM To: mrash/fwknop @.> Cc: Damien Stuart @.>; Mention @.> Subject: Re: [mrash/fwknop] Fixes for macOS build (PR #361)

@damienstuarthttps://github.com/damienstuart should I change the version number or is that only done after a release?

— Reply to this email directly, view it on GitHubhttps://github.com/mrash/fwknop/pull/361#issuecomment-1913324262, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGRNJG5QCUH6H6JFTN274DYQVN5RAVCNFSM6AAAAABCJB7CY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGMZDIMRWGI. You are receiving this because you were mentioned.Message ID: @.***>

mrash commented 7 months ago

Thanks, with these latest updates seems like we should go ahead and publish the next version.

Mike

On Sat, Jan 27, 2024 at 3:25 PM Damien Stuart @.***> wrote:

Merged #361 https://github.com/mrash/fwknop/pull/361 into master.

— Reply to this email directly, view it on GitHub https://github.com/mrash/fwknop/pull/361#event-11617871521, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC42RH7OHMRQMPM3ZZGX4TYQVPEDAVCNFSM6AAAAABCJB7CY6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGYYTOOBXGE2TEMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>