mrcjkb / rustaceanvim

🦀 Supercharge your Rust experience in Neovim! A heavily modified fork of rust-tools.nvim

GNU General Public License v2.0

1.62k stars 58 forks source link

feat(lsp): Arguments to explainError/renderDiagnostic from current line #431

Closed Rumi152 closed 3 months ago

Rumi152 commented 3 months ago

feat(lsp): explainError and renderDiagnostic command now have optional argument {cycle?|current?}. It default to cycle which is current behavior, current option makes it search for diagnostic only in the current cursor line

github-actions[bot] commented 3 months ago

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

For example, fix(lsp): some lsp-related bugfix
[ ] Pull request title has the appropriate conventional commit prefix.

If applicable:

[ ] Tested
- [ ] Tests have been added.
- [ ] Tested manually (Steps to reproduce in PR description).
[ ] Updated documentation.
[ ] Updated CHANGELOG.md

Rumi152 commented 3 months ago

Its my first more serious pull request so I'm sorry if I did something wrong, I don't know how to install nix on windows

Rumi152 commented 3 months ago

429

mrcjkb commented 3 months ago

Hey, thanks for the contribution. 🙏 This is definitely a great idea!

I'm quite busy at the moment but I'll make sure to give it a review and a test drive in the next few days 😃

mrcjkb commented 3 months ago

CI is failing because stylua needs to be run.

Rumi152 commented 3 months ago

I'll try to figure it out

Rumi152 commented 3 months ago

I think it should work now

Rumi152 commented 3 months ago

Sorry for all the headache I've caused and thanks for this great plugin 😄