mrglassdanny / vscode-moca-client

MOCA Client Extension for Visual Studio Code
MIT License
10 stars 2 forks source link

'Disconnect' command #34

Open Xavierpa91 opened 2 months ago

Xavierpa91 commented 2 months ago

Hi,

First of all I would like to congratulate you for the excellent work of this extension (MOCA CLIENT) in Visual Studio. I am working on an internal project and I am interested in being able to change the connection between instances, automatically, so, just as there is a command to execute the 'MOCA: 'Connect to MOCA Server', I am missing a 'MOCA: Disconnect to the MOCA server'. Do you know if this functionality will exist? I would be happy to help with the process and development of new functionality in this extension if necessary! ;)

Again, thank you very much for everything and congratulations on the great work done!

Regards,

Xavi

mrglassdanny commented 1 month ago

Hi Xavi -- Sorry I am so slow seeing this! Thank you for your kind words!

I considered creating a disconnect command, though I guess I didnt really think it was necessary. The MOCA server should cleanup sessions after a while. If you just connect to a new instance, your old instance's session should be cleaned up pretty quickly. What are your thoughts? Do you think a disconnect is necessary?