search

mrhappyasthma / IsThisStockGood

A tool for evaluating companies using the Rule #1 investing principles.
http://www.isthisstockgood.com
22 stars 10 forks source link

Yahoo finance analysis seems to be silently failing. #43

Closed mrhappyasthma closed 2 years ago

mrhappyasthma commented 2 years ago

The yahoo_finance_analysis still exists, but yahoo_finance_analysis.five_year_growth_rate is null.

This is occurring even for tickers with valid data. E.g. https://finance.yahoo.com/quote/FB/analysis?p=FB

mrhappyasthma commented 2 years ago

Seems like a 404 error in https://github.com/mrhappyasthma/IsThisStockGood/blob/master/src/DataFetcher.py#L233.

URL is https://finance.yahoo.com/quote/fb/analysis?p=fb.

mrhappyasthma commented 2 years ago

Strangely the URLs match. So it's not entirely clear why 404 is being returned.

mrhappyasthma commented 2 years ago

It seems likely to be a user-agent problem.