search

mrhappyasthma / IsThisStockGood

A tool for evaluating companies using the Rule #1 investing principles.
http://www.isthisstockgood.com
22 stars 10 forks source link

Calculate roic_1 and roic_3 from Yahoo Finance if possible + tests #64

Closed losgrandes closed 1 year ago

losgrandes commented 1 year ago

This fix is for problem described in https://github.com/mrhappyasthma/IsThisStockGood/issues/63.

Please double check my reasoning on how to calculate ROIC in method _get_roic_history inside YahooFinanceQuoteSummary class.

mrhappyasthma commented 1 year ago

I'll take a look at this code later this weekend. Thanks again for all the pull requests to help improve the site :)

losgrandes commented 1 year ago

Thanks for all your suggestions! I'll come back to this sometime this week.

losgrandes commented 1 year ago

All set. Please review. :)