search

mrhappyasthma / IsThisStockGood

A tool for evaluating companies using the Rule #1 investing principles.
http://www.isthisstockgood.com
22 stars 10 forks source link

UI / UX changes : closes #41 #68

Closed lukaqueres closed 1 year ago

lukaqueres commented 1 year ago

Changed ticker input validation method to regex.

Added loading popup

mrhappyasthma commented 1 year ago

Thanks for the PRs :)

[copy/pasted from my comment on the other thread:]

Would it be possible to replace the tabs back to 2x spaces indentation? It's hard to isolate the actual changes in the diff since every line is modified.

(I'm open to changing the amount of spacing, but if possible let's isolate that. Seems like the Google styleguide recommends 4x spaces, which I also wasn't adhering to: https://google.github.io/styleguide/pyguide.html#34-indentation)

lukaqueres commented 1 year ago

I can correct it, somehow I made it so that in this PR is also the previous one, fixing errors undefined.

lukaqueres commented 1 year ago

Sorry for so many problems, damn indentations

mrhappyasthma commented 1 year ago

This looks awesome! Thank you for adding this.

lukaqueres commented 1 year ago

All the pleasure is mine, glad to help :D

lukaqueres commented 1 year ago

Fixed Regex, should now support -, , and ., I have very little expirience with tickers, so I can only count on feedback.

lukaqueres commented 1 year ago

So, hopefully now it will be ok 👍

mrhappyasthma commented 1 year ago

Looks good!