mrhappyasthma / IsThisStockGood

A tool for evaluating companies using the Rule #1 investing principles.
http://www.isthisstockgood.com
22 stars 10 forks source link

Fixes to the JS and major problem with yahoo API #69

Closed lukaqueres closed 3 months ago

lukaqueres commented 1 year ago

I have already fixed problem with JS loading. Loading pop-up is still displaied in case of any error, should be fixed now.

But Yahoo

Yahoo has gone mad, and closed this https://query1.finance.yahoo.com/v7/finance/quote?symbols={} endpoint ( the v6 returns 404 ). I wasted way too much time trying to find an issue, just to figure out, that there was a message ( easiest way to see: https://query1.finance.yahoo.com/v7/finance/quote?symbols=MSFT ):

image

Link leads to google form:

image

With this question especially funny:

image

So yea, no data from this source.

kocielnik commented 1 year ago

Thanks for describing your findings here in detail, @lukaqueres! :)

There may still be some other API that will provide that info for us.

The docs for Google Sheets you shared from https://support.google.com/docs/answer/3093281 also look like something that could be valuable here.

mrhappyasthma commented 1 year ago

Agreed. The best option here is simply to find an alternative. Sadly. :(

mrhappyasthma commented 1 year ago

Interestingly only the YahooFinanceQuote is failing. The YahooFinanceQuoteSummary still appears to work.

The data missing from the quote is:

  1. current price
  2. market cap
  3. stock name (from ticker)
  4. average volume per day
  5. TTM EPS

Aside from 'maybe' the TTM EPS, none of the other values are anything too difficult to find from other data sources.

mrhappyasthma commented 1 year ago

Its been a while, so I traced where all our data comes from (to make it easier to track if an API goes down or we find a better alternative for anything):

https://github.com/mrhappyasthma/IsThisStockGood/wiki/Data-fetching---scraping-overview