search

mrzachnugent / react-native-reusables

Universal shadcn/ui for React Native featuring a focused collection of components - Crafted with NativeWind v4 and accessibility in mind.
https://rnr-docs.vercel.app
MIT License
3.46k stars 145 forks source link

[ BUG ] Dialog not closes on outside click, close button not working. #254

Open kerimovok opened 2 weeks ago

mrzachnugent commented 2 weeks ago

Hey @kerimovok, please provide a minimal reproduction repo as I am unable to reproduce this issue.

kerimovok commented 2 weeks ago

Steps to reproduce:

  1. Create Expo project
  2. Add the Dialog component manually as shown in docs for native only
  3. Add code example from docs and test on mobile device

I tried some props on DialogOverlay, but still not working, close button also not working

Tested on: iOS 17 iPhone X

Thank you for project

kaumac commented 1 week ago

This (click outside to close) is actually not working on the demo page: https://rnr-showcase.vercel.app/alert-dialog

Also there's no close/exit animation, curious if this is a limitation of the implementation or if its a bug

mrzachnugent commented 1 week ago

@kaumac That is desired behaviour. See https://ui.shadcn.com/docs/components/alert-dialog for reference. As for the animations, it seems like a bug.

kaumac commented 1 week ago

thanks for clarifying that @mrzachnugent

The animation issue seems to be project wide. The same happens with the tooltip component. I'll create a separate issue for this.