search

mrzv / dionysus

Library for computing persistent homology
http://mrzv.org/software/dionysus2
Other
144 stars 31 forks source link

MSVC Build fix #30

Closed jvuillamy closed 5 years ago

jvuillamy commented 5 years ago

The additional "template" keywords created an error C2244 "Unable to match function definition to an existing declaration" when building.

jvuillamy commented 5 years ago

Removing the "template" keywords does not build on GCC. Closing the PR.

mrzv commented 5 years ago

Are you saying that with this fix the code compiles under MSVC? If yes, that would be fantastic and we could wrap the difference in compile-time guards.

jvuillamy commented 5 years ago

Hi, This does fix the issue under MSVC.

mrzv commented 5 years ago

Can you try the windows branch? If it compiles under MSVC (and Python bindings work), it would be amazing.

jvuillamy commented 5 years ago

Hi Dmitriy, The compile guard works on windows with MSVC !

mrzv commented 5 years ago

Amazing. Are you compiling it using the cmake; make ... route? Or are you using pip install ...? Do Python bindings work? One way or another, it sounds like I should merge that branch into master.