msadowski / x2_cartographer

Using YDLIDAR X2 with Google Cartographer ROS package
16 stars 4 forks source link

Resource not found: ydlidar #4

Open supermat151 opened 1 year ago

supermat151 commented 1 year ago

I know this form is really old but I am trying to use your lua code with my own x2 lidar project.

I've done some research and the git submodule update --init does not work with your current URL.

https://github.com/YDLIDAR/ydlidar/ no longer exists.

I believe the website has been updated to https://github.com/YDLIDAR/ydlidar_ros_driver. However when I forked your repository and update the url to : git@github.com/YDLIDAR/ydlidar_ros_driver.git, then cloned over my repository with this updated URL, it produces an error that says:

fatal: not a git repository (or any of the parent directories): .git

When trying to run your command of "roslaunch carto_mapper mapper.launch", it produce an error that says "Resource not found: ydlidar" which I believe is caused from the submodule update not having the proper URL.

Your help would be appreciated to know what the proper URL structure should be for this submodule

Thanks in advanced

msadowski commented 1 year ago

Hi,

Yes, this is super old, and I won't be maintaining it.

The steps to fix this would roughly be as follows:

  1. Remove the ydlidar submodule following the answer here
  2. Add a new submodule for ydlidar executing git submodule add git@github.com:YDLIDAR/ydlidar_ros_driver.git

Since these are just directories, you might also simply delete the ydlidar directory from the repo, copy over the new ydlidar package and it should still build.