Closed jpacelli62 closed 3 years ago
thanks 👍 yes I meant in all the source files of the solution (except generated files if they're affected) we should use four spaces instead of tabs - I can still see some files with tabs in the review (eg Equipment.cs)
it looks good so far I'll review more thoroughly soon
that looks good
have you tested this version locally using your own logs?
I upgraded filters to do like @technology and @synthesis and I improved the "All" filter behaviour + refresh one time only the GUI on click. I also fixed some issues.
thank you for the changes
I think you should split the other changes (commander's loading and filter update) in a separate review, it doesn't seem directly linked to the journal update handling and will make it easier to review
I'm sorry but I don't use to contribute to github projects, I don't know how to split. Sorry also for my level of English, I am French too
It's done for JournalEntryConverter, is there other files? I don't know how you think matching equipment / codes with UpgradeOperation but it works as it, please check it. Please also use my CMD name on release note: DrDoomDmc