msinger / dmg-schematics

Reverse engineered schematics of the Game Boy's DMG-CPU B chip
Creative Commons Attribution Share Alike 4.0 International
14 stars 14 forks source link

Bus labels ending in underscore #135

Closed msinger closed 2 years ago

msinger commented 2 years ago

For some reason you added an underscore at the end of most sprite related bus labels (like SAVE_SPRITEX[0..9]). Although, this may look good for the individual wires coming out of those buses (SAVE_SPRITE_X_0), it is inconsistent with other buses (like OAM_PARSE_A[2..7]). More bothering to me is that when we translate this schematics one-to-one to Verilog or VHDL, we would end up with ugly vector or array names that have this underscore at the end.

rgalland commented 2 years ago

True, this is a good point.

rgalland commented 2 years ago

Changed other buses too.

msinger commented 2 years ago

SPRITEX and SPRITEON still have _