mskcc / pluto-cwl

CWL workflows for helix filter scripts
1 stars 6 forks source link

Add Normal sample ID's to the fillout workflows #95

Closed stevekm closed 2 years ago

stevekm commented 2 years ago

This requires refactoring the input schema into an array of records.

stevekm commented 2 years ago

@allanbolipata the updated input schema is shown here;

https://github.com/mskcc/pluto-cwl/blob/342e6f1f4f7a3839e579fbe96ccc8d6f7a61ac77/tests/test_samples_fillout_index_workflow_cwl.py#L41-L70

stevekm commented 2 years ago

This needs some changes

Not all samples should go through maf_filter step. For our workflows, clinical samples are assumed to have been previously curated and should not be filtered again. However research samples have not been curated so should be filtered

The following things need to be changed

@allanbolipata @timosong

stevekm commented 2 years ago

also I think we should be able to include bam_file in the sample records instead of having it as a separate input array

stevekm commented 2 years ago

also I think we should be able to include bam_file in the sample records instead of having it as a separate input array

forget about this for now, I had forgotten that there are still issues with CWL version 1.0 and array record entries having secondary files