search

msolefonte / celes

Celes is an open source file scraper that obtains and stores game achievements, whatever the origin
https://www.npmjs.com/package/@achievement-watcher/celes
GNU General Public License v2.0
4 stars 0 forks source link

Add a logger #21

Closed msolefonte closed 4 years ago

msolefonte commented 4 years ago

Based on Winston, passed on creation.

msolefonte commented 4 years ago

Logger should also be passed to the plugins.

msolefonte commented 4 years ago

I started working on a logger but finally deleted it completely again. I just find it too ugly.

I'll consider introducing it only to log errors and warnings.

msolefonte commented 4 years ago

As said before, I was not comfortable with introducing a logger in a library. Finally, I decided to introduce an integrated error reporter in #40, based on an object Scrap Error. A list of them, if existent, is returned together with the games data after calling Celes.pull().