msp1974 / homeassistant-jlrincontrol

An integration for JLR InControl to Home Assistant
MIT License
66 stars 12 forks source link

V3.0.0Beta7 issues #142

Open BNWEIN opened 6 months ago

BNWEIN commented 6 months ago

The problem

Hi. I am using V3.0.0Beta7 and i cannot get the "Climate (Engine)" button to work. Even using the old method of calling the "Jaguar LAndorver inControl: start_vehicle" service also does not work.

Using the first option "Climate (Engine)" button nothing appears in my logs and the car does not start.

Using the second option: Jaguar Landorver inControl: start_vehicle" i do get the below in the logs, but the car does not start

image

The PIN is all configured in the settings and this has all previously worked.

What version of JLR Home Assistant Integration has the issue?

V3.0.0Beta7

What was the last working version of JLR Home Assistant Integration?

No response

Vehicle type and model

Landrover Discovery

Diagnostics information

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

BNWEIN commented 6 months ago

I have done some further testing.

Deleted the integration all together. Re-Installed 2.2.7 Issue persists

Locking and Unlocking via HA Works fine. but starting the car/climate does not.

BNWEIN commented 6 months ago

Trying to call the service manually also does not work

image

and after downgrading to 2.2.7 i no longer get an error or anything in the log when doing the above.

msp1974 commented 6 months ago

This is a known issue in the jlrpy library. It has been fixed in the master branch but not yet released. I will ask @ardevd to make a release so we can update it in this integration to fix this.

In the meantime, if you want to have a go at fixing yourself, see this issue. https://github.com/ardevd/jlrpy/issues/120#issuecomment-2072862792

BNWEIN commented 6 months ago

This is a known issue in the jlrpy library. It has been fixed in the master branch but not yet released. I will ask @ardevd to make a release so we can update it in this integration to fix this.

In the meantime, if you want to have a go at fixing yourself, see this issue. ardevd/jlrpy#120 (comment)

Thanks for confirming. I would love to give the fix a go my self, but i am not clear what file to edit? Could you advise? Also if i edit the file, this wont affect, when you then fix it and i update via HACS?

Thanks again for coming back to me so soon!

ardevd commented 6 months ago

I'll release a new version of jlrpy over the weekend.

BNWEIN commented 6 months ago

I'll release a new version of jlrpy over the weekend.

Sorry to be a pain, I don’t suppose you managed to get this patched?

ardevd commented 6 months ago

jlrpy v1.7.1 has now been published. Thank you for your patience.

BNWEIN commented 6 months ago

jlrpy v1.7.1 has now been published. Thank you for your patience.

Thank you! @msp1974 do I need to wait for an update to this repo?

msp1974 commented 6 months ago

Yes. I'll do tomorrow.

dcs7189 commented 6 months ago

Vehicle (2018 Jaguar R575) start/stop now working for me after update. Thanks!

BNWEIN commented 6 months ago

Vehicle (2018 Jaguar R575) start/stop now working for me after update. Thanks!

I’m confused? How did you get it working? I don’t have any updates available?

dcs7189 commented 6 months ago

Strange. I was running 2.2.7, had the issue where the vehicle would fail to respond to a start command with nothing reported in the logs. So I downloaded the 3.0beta7, copied the contents of the zip file over the 2.2.7 installation, restarted HA and then reattempted. Vehicle promptly started/stopped as expected. I assumed the 3.0beta7 had been updated with the jlrpy fix mentioned above.

BNWEIN commented 6 months ago

Strange. I was running 2.2.7, had the issue where the vehicle would fail to respond to a start command with nothing reported in the logs. So I downloaded the 3.0beta7, copied the contents of the zip file over the 2.2.7 installation, restarted HA and then reattempted. Vehicle promptly started/stopped as expected. I assumed the 3.0beta7 had been updated with the jlrpy fix mentioned above.

Well this is really odd! I have not updated the integration but mine has also started working. Now I’m wondering if JLR updated their own API?

dcs7189 commented 6 months ago

Ah, perhaps so. My change was probably coincidental. I might go back to 2.2.7. Glad this prompted you to give it another try and it's working now!

dcs7189 commented 6 months ago

2.2.7 working nicely as well. Thanks guys.