msp1974 / homeassistant-jlrincontrol

An integration for JLR InControl to Home Assistant
MIT License
60 stars 11 forks source link

Two cars in two different JLR Incontro accounts (services calls don't work for the second vehicle to be called) #92

Open CorceiroPT opened 1 year ago

CorceiroPT commented 1 year ago

At home we have two JLR vehicles in two different InControl account (mine's and my wife's). I have both configured on the integration (just trying to add a "new" integration, it asks for another username and InControl password).

image

image

What happens is that the entities (range information and so on) work well on both cars, but the services will only run on the first one that is called (unlock doors, honk and blink, etc.). To call services on the second car it's necessary to reload the integration first (and after that the services calls to the other car stop working until you reload it again).

I think it may be a problem with the tokens variables. Maybe only tokens of the first car to be called are stored and them trying to use those tokens on the other InControl account won't work.

msp1974 commented 1 year ago

Just so you know I am not ignoring this. Doing some significant rework on the integration to bring up to modern standards and will address this as part of that. Maybe a few weeks.

ismarslomic commented 1 year ago

@msp1974: great news! Just courious what you think about migrating this custom component to HA core integration? I know its off topic in this thread, maybe we should discuss it in separate one?

CorceiroPT commented 1 year ago

Just so you know I am not ignoring this. Doing some significant rework on the integration to bring up to modern standards and will address this as part of that. Maybe a few weeks.

Thank you very much for your time!

msp1974 commented 5 months ago

This should be resolved in v3.0.0beta1 but will leave open until released and confirmed.