search

mtekman / org-tanglesync.el

A package to pull external changes into an org-mode source block if that block is tangled to an external file
GNU General Public License v3.0
90 stars 7 forks source link

Fix some issues with watch hook #10

Closed CeleritasCelery closed 4 years ago

CeleritasCelery commented 4 years ago

Two Things here:

When org-tanglesync-watch-mode is enabled it was making a copy of every buffer every time it was saved. There is no need to do that since there are very few files that we will actually need to make a copy. Imaging trying to save a 1 gig log file only to have emacs make a copy of it each time. We should only make copies of files we know we will need (Though to be entirely honest not sure why it is making a copy in the first place instead of just fetching the original buffer).

Loading a package should never add hooks to the user config unless the user enables them. I moved the hooks into minor modes. If users follow the setup you give the behavior will be the same.

mtekman commented 4 years ago

so I made a minor fix to your PR here https://github.com/CeleritasCelery/org-tanglesync.el/pull/1 If you can merge that, I can merge this!

CeleritasCelery commented 4 years ago

Should be good. Please take a look.

mtekman commented 4 years ago

Good stuff, thank you!

Btw, do you know of the proper way I can push changes to someone else's PR? I felt that the method I chose (to make a PR to your master) was a bit convoluted.

CeleritasCelery commented 4 years ago

If the PR author enabled "Allow edits from maintainers" (which is on by default), then you can clone my fork and push changes directly to my PR branch! They will show up in the PR just as normal commits without you having to open PR on me.