changed search url to serve up #javascript tweet hashtag also

mtliendo / jcs-js-tips-api

An api to list the latest #JCsJSTips from twitter

https://evening-basin-16610.herokuapp.com/jcs-js-tips

3 stars 1 forks source link

changed search url to serve up #javascript tweet hashtag also #1

Closed Oghenebrume50 closed 5 years ago

Oghenebrume50 commented 5 years ago

This makes it serve more tweets and the one for 2nd July also. With the #javascript we could get tweet we do not need also, but we can also clean that up with a search for keywords like challenge, lesson and class in the tweet.

Oghenebrume50 commented 5 years ago

For now, the content we get is fine, I checkedout the repl.it link you sent I feel that will require manually putting those content up in the API, I don't think we can scrap content off repl.it, worse how do we avoid duplicates

Oghenebrume50 commented 5 years ago

Bullet points of all I did

Removed the end date from the search string, because it works with timezone, I observed it in the last post, when Jchaitt made it, it didn't show up until I removed it.
sorted the api output with the date in descending order. I just noticed the current output comes out as sorted but this doesn't happen in my local environment, maybe an overkill.
Added tags query to support array,prototype and scope, either or a combination of any. solution to issue #2 Below is the output of some of the query.

Oghenebrume50 commented 5 years ago

@mtliendo Please review so I know if I am on track or not.

mtliendo commented 5 years ago

This is awesome work, thanks so much. In this case, how would someone go about receiving all the challenges, regardless of tags? The last screenshot you posted looks like nothing gets returned.

Oghenebrume50 commented 5 years ago

This is awesome work, thanks so much. In this case, how would someone go about receiving all the challenges, regardless of tags? The last screenshot you posted looks like nothing gets returned.

Hi, I left that as it was before now, the last screenshot shows when someone does not pass a value to the tags query key. maybe I should change the url to be similar that is like this

get all contents: /jcsjs-lessons
get content based on tags: /jcsjs-lessons?tags=parameters

mtliendo commented 5 years ago

get all contents: /jcsjs-lessons get content based on tags: /jcsjs-lessons?tags=parameters

That sounds like a plan. If you don't mind pushing that commit up and I'll go ahead and merge. Thanks again for all your work on this!

Oghenebrume50 commented 5 years ago

You are welcome, I am just determined to improve my skills and open source experience. It is done, the uri is /jcsjs-lessons we may need to add this to the readme file, and maybe how to use the supported tags too

mtliendo commented 5 years ago

PR is merged. I'll push to the server later on today