search

mtmse / pipeline-mod-mtm

MTM specific modules for the DAISY Pipeline 2
0 stars 0 forks source link

Datatypes #12

Closed bertfrees closed 8 years ago

bertfrees commented 8 years ago

See https://github.com/snaekobbi/pipeline-mod-mtm/issues/4

Please don't merge yet.

@joeha480 I've given Ammar push access to this repo so that he can play around with the datatypes a bit. Feel free to restrict access again later.

@usama49 I've committed an example datatype (mtm:line-spacing) and also added a test. In order to run this you need https://github.com/daisy/pipeline-framework/pull/97 and https://github.com/daisy/pipeline-build-utils/pull/18.

bertfrees commented 8 years ago

@josteinaj In order to test this with the web UI, it's maybe easiest to just drop the snapshots of mod-mtm, framework-core, webservice and webservice-utils in the system folder of a pipeline server instance.

josteinaj commented 8 years ago

@bertfrees Ok, sounds reasonable. I'm currently trying to pinpoint a problem with webservice and/or webservice-utils though. The master branch of pipeline-framework doesn't work. That is, the Web API doesn't respond when building the newest assembly (v1.9.7) with the newest framework (1.10.0-SNAPSHOT).

bertfrees commented 8 years ago

OK. I was thinking about how to test this including the webservice. Something along the lines of what Javi did here: https://github.com/daisy/pipeline-it/tree/master/daisy/framework-integration/src/test/java/org/daisy/integration. Maybe I'll refactor it a bit someday so that it can be used from any JUnit test (with Pax Exam) with any modules included. (Currently it relies on building and running the assembly.)

josteinaj commented 8 years ago

@bertfrees so @usama49 can just commit to this PR, right?

bertfrees commented 8 years ago

Yes.