multiply-org / multiply-core

The core functionality of the MULTIPLY platform
2 stars 5 forks source link

Module naming convention #1

Closed bulli92 closed 7 years ago

bulli92 commented 7 years ago

Avoid to have any '-' in the names of the modules and project names. This is not compliant with the python coding style conventions and results in import errors.

A statement import multiply-dummydoes not work.

In the PEP8 conventions it says that

Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.

Thus recommendation would be to replace multiply-dummywith multiply_dummy

TonioF commented 7 years ago

The module has been renamed. If further violations of the PEP-8 should occur, we may open new issues - I don't think that renamings are worth raising issues, though.