search

multiversx / mx-chain-observing-squad

Docker images and scripts for setting up an MultiversX Observing Squad
11 stars 12 forks source link

update go base image versions #33

Closed muhlemmer closed 1 year ago

muhlemmer commented 2 years ago

This pull request updates the Go base image versions. Images were using a mix of Go versions 1.14 and 1.15, both are no longer supported or receiving important security fixes.

From https://go.dev/doc/devel/release:

Each major Go release is supported until there are two newer major releases. For example, Go 1.5 was supported until the Go 1.7 release, and Go 1.6 was supported until the Go 1.8 release. We fix critical problems, including critical security problems, in supported releases as needed by issuing minor revisions (for example, Go 1.6.1, Go 1.6.2, and so on).

Basically with the latest release earlier this month, only Go version 1.17 and 1.18 are still maintained. This PR upgrades directly to 1.18.

I've tested the build of all images, but not running all the variants. But since Go is a forward-compatible statically typed language this should be fine.

Note that the build of utils/elrond-go-keygenerator fails (also with the older version of Go) as reported in #31 and fix proposed in #32.

miiu96 commented 1 year ago

The images were updated in this PR https://github.com/multiversx/mx-chain-observing-squad/pull/52 thank you for your feedback