search

muppet3000 / homeassistant-grott

Home Assistant Integration for Grott - MQTT
MIT License
65 stars 14 forks source link

Factoring error on battery discharging data #3

Closed benhumphry closed 1 year ago

benhumphry commented 1 year ago

I think there is a factoring error on battery discharging data; It seems to be 1,000 times bigger than it used to be!

image

muppet3000 commented 1 year ago

Wow, ok I'll take a look at that on my own system tonight!

Can you let me know what type of system you have please? e.g. what you configured grott as e.g. mix, tlx etc.

benhumphry commented 1 year ago

Hi - I have an SPH hybrid system

benhumphry commented 1 year ago

In fact - not your error - it is from egguy addon; pdischarge1 unit of measurement is incorrectly configured as kWh (not W) in MQTT

muppet3000 commented 1 year ago

Ah, cool, thanks for updating. The one thing I'm not certain about is that I've just seen that there's a difference in my local running grott instance which means that the statement of charge % may be calculated incorrectly. I'll compare that tonight (I hacked my local copy to make some other things working when I was testing things) to make sure it's working correctly. Is the battery % showing correctly for you?

Are you going to feed back the bug to egguy for his add-on?

P.S - It's awesome that it works with his add-on because it's nice people can have the whole thing integrated into one stack (if you have the version of HA that supports add-ons).

benhumphry commented 1 year ago

The SoC seems to be correct, yes - certainly reporting the same as ShinePhone.

I've reported the bug to egguy here: https://github.com/egguy/grott-home-assistant-add-on/issues/26 - I'll update if he responds.

I didn't even realise I was trying something new! I came across the add-on first, and was just about to figure out how to import all the MQTT values to HA before I came across your integration... embarrassingly, I didn't even read the installation instructions - it just worked!

muppet3000 commented 1 year ago

That's awesome, I literally only 'released' it last night (I've been working on it for weeks, it just took me forever to properly document it).

benhumphry commented 1 year ago

Ah yes - but I saw your "don't install this" note prior to release and couldn't resist.