search

mwilliamson / spur.py

Run commands and manipulate files locally or over SSH using the same interface
BSD 2-Clause "Simplified" License
267 stars 37 forks source link

load readme as utf8 #37

Closed zbyte64 closed 8 years ago

zbyte64 commented 8 years ago

Fix #36

mwilliamson commented 8 years ago

I don't think open on Python 2 supports the encoding argument, does it?

zbyte64 commented 8 years ago

Blast, you are correct. Maybe codes.open instead?

https://docs.python.org/2/library/codecs.html#codecs.open

mwilliamson commented 8 years ago

I think io.open is probably more appropriate, since that's what open is on Python 3.

mwilliamson commented 8 years ago

I'm still confused by why you're getting the error in the first place. So far as I can tell README.rst doesn't contain any non-ASCII characters.

Does tox pass on all platforms with the change?

mwilliamson commented 8 years ago

Removed the non-ASCII character from README.rst. Let me know if I missed any, or if there are any other issues.