[LEGACY] [0023] Resolve surrender capture side casualty gremlins

[mwpowellhtx]

Basic Information

Mission version: v0.97.0a Map used: Altis Mods used: Base set, including ACE, RHS Dedicated or local game: Local (for now)

Short Issue Description

• [x] When units surrender this invokes setCaptive, which forces civilian side convertion
• [x] Therefore it is necessary to introduce a baseline sidedness variable on the units involved prior to doing these things
• [x] Best possible place we think of doing this is during the prisoner_ai server side callback
• [x] In addition any references to side _x, side group _x, and so on, need to filter through KPLIB_fnc_side function

[mwpowellhtx]

As much bug as it is non-trivial, best case minor, worst case major, enhancement. Mostly have it sorted now, but it did expose the necessity for some increased biases while evaluating for sector ownership, unit surrender, and so forth.

[mwpowellhtx]

In addition to which, was observing that when mistakes are made, captive executions and so forth, this kicks the offender out into no man's land, group wise, it seems like. Any actions the offender was previously able to do, such as capture currently surrendered units, are nilified it seems like. Working with newly surrendered units seems ot be fine however.

Not sure why this is, if it is mod related, thinking probably base game, difficulty, perhaps ACE settings. However, the core issue being addressed, seeing captured, interrogated, units as civilian, avoiding consequent penalties therein, that much has been addressed.

Not sure it is worth pursuing this other idiosyncacy, outside of making this report, and leaving space for potential lessons learned moving forward into earnest redeux efforts.

[mwpowellhtx]

Closing this one, but if something jumps out as a plausible root cause, let alone what we may do about it further than we have, will reconsider additional steps.

[mwpowellhtx]

Consolidation done, should track in the parent issue instead.

[mwpowellhtx]

We have sorted the capture action menu issue successfully. Also verified through civilian informant use cases. Although, to be clear, civilian informant was a whole other elongated pasta dish in of itself, did address some of this in a follow on issue.