Closed Anurag-Raut closed 1 year ago
Name | Link |
---|---|
Latest commit | 8ff0cdde752d23b28d700dba4f74fc072804dadf |
Latest deploy log | https://app.netlify.com/sites/ytify/deploys/643830ceb664e00008da340a |
Deploy Preview | https://deploy-preview-105--ytify.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Have you tested the code for multiple types of streams?
I have tested it on videos with multiple subtitles and it was working, can you please elaborate what are streams, and how can I test it on multiple streams?
I have tested it on videos with multiple subtitles and it was working, can you please elaborate what are streams, and how can I test it on multiple streams?
Streams = videos. So that is fine. In the context of ytify, calling them streams make more sense since they are just links from youtube, and are used for audio streams.
I have tested it on videos with multiple subtitles and it was working, can you please elaborate what are streams, and how can I test it on multiple streams?
Streams = videos. So that is fine. In the context of ytify, calling them streams make more sense since they are just links from youtube, and are used for audio streams.
Ok understood, is there anything else I need to do?
I have tested it on videos with multiple subtitles and it was working, can you please elaborate what are streams, and how can I test it on multiple streams?
Streams = videos. So that is fine. In the context of ytify, calling them streams make more sense since they are just links from youtube, and are used for audio streams.
Ok understood, is there anything else I need to do?
Nope, ill just make some tweaks and merge it to v5.10 branch.
for videos that have both auto generated as well as proper english subs which one is being used? https://ytify.netlify.app/?s=74ijsBhbxSQ
for videos that have both auto generated as well as proper english subs which one is being used? https://ytify.netlify.app/?s=74ijsBhbxSQ
this was the priority-> 1)english subs+ not autogenerated 2) english subs + autogenerated 3)first subtitle in the array I did this by checking if code =="en" but it failed in the above video because the subtitle code was "en-gb", I have solved this by checking if the code include en by js function .includes(), Now its working on the stream you provided.
extracted English subs if there are multiple subtitles, also the set the preference for subtitles as - 1)english subs+ not autogenerated 2) english subs + autogenerated 3)first subtitle in the array