search

n-ce / ytify

Opus Audio Streaming Web App for YouTube. Stop watching, Listen & Save Data.
https://ytify.netlify.app
GNU General Public License v3.0
145 stars 48 forks source link

Volume controller feature branch #113

Closed Udara98 closed 1 year ago

Udara98 commented 1 year ago

This change resolves #112 by adding a volume controller for the ytify player, enabling users to control the audio volume level and mute the volume during media playback.

netlify[bot] commented 1 year ago

Deploy Preview for ytify ready!

Name Link
Latest commit 172a590391ca9a5499e55db8895581641d99124c
Latest deploy log https://app.netlify.com/sites/ytify/deploys/64a6bc810d731a0008f4c092
Deploy Preview https://deploy-preview-113--ytify.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

n-ce commented 1 year ago
  1. it's overflowing in mobile
  2. you have to use a html select not an input range
Udara98 commented 1 year ago

it's overflowing in mobile could you mention the screen size or device on which you observed the overflow? So, I can fix that error, I hope the input range is better than html select in the user experience.

n-ce commented 1 year ago

I hope the input range is better than html select in the user experience.

yes I do realize that, but you would notice there is not much space for it in mobile view. if you are adamant on keeping the input range. We might consider a volume button that launches a volume controller popup/modal just above the player controls, this way both the ux and ui is not compromised.

Udara98 commented 1 year ago

Yes. It will be better,I can implement this feature using html select tag.