n-ce / ytify

Audio Streaming Client for YouTube. Cherish the Art of Listening.
https://ytify.netlify.app
GNU General Public License v3.0
174 stars 52 forks source link

Added custom HTML audio player #49

Closed KysonnDelaCerna closed 2 years ago

KysonnDelaCerna commented 2 years ago

this commit fixes #45

netlify[bot] commented 2 years ago

Deploy Preview for ytify ready!

Name Link
Latest commit 69da3ba29d246ff9eb0962284e8be824d021c409
Latest deploy log https://app.netlify.com/sites/ytify/deploys/62da66175063740008523e18
Deploy Preview https://deploy-preview-49--ytify.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

n-ce commented 2 years ago

Can you describe your pr? Like about the things you have changed

KysonnDelaCerna commented 2 years ago

These are the things I changed

n-ce commented 2 years ago

I've seen you've commented a lot of prior code, is this going to be problematic? Going forward with your PR, will there remain any conflicts? It adds a whopping 100+lines of code, so make sure it is maintainable for future developers to read and understand.

KysonnDelaCerna commented 2 years ago

I just made it so that the styles are now tied to a class instead of the HTML tags so if they're going to be reused in the future you can just assign that class.

n-ce commented 2 years ago

Okay LGTM, thanks for the PR!

n-ce commented 2 years ago

Btw would you like to attempt, coloring the progress bar according to the theme colors? Now that the default player is gone, we also need a speed changer.

KysonnDelaCerna commented 2 years ago

I'll look into it