Closed KysonnDelaCerna closed 2 years ago
Name | Link |
---|---|
Latest commit | 69da3ba29d246ff9eb0962284e8be824d021c409 |
Latest deploy log | https://app.netlify.com/sites/ytify/deploys/62da66175063740008523e18 |
Deploy Preview | https://deploy-preview-49--ytify.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Can you describe your pr? Like about the things you have changed
These are the things I changed
I've seen you've commented a lot of prior code, is this going to be problematic? Going forward with your PR, will there remain any conflicts? It adds a whopping 100+lines of code, so make sure it is maintainable for future developers to read and understand.
I just made it so that the styles are now tied to a class instead of the HTML tags so if they're going to be reused in the future you can just assign that class.
Okay LGTM, thanks for the PR!
Btw would you like to attempt, coloring the progress bar according to the theme colors? Now that the default player is gone, we also need a speed changer.
I'll look into it
this commit fixes #45