Improving Desktop View - Githubissues

n-ce / ytify

Opus Audio Streaming Web App for YouTube. Stop watching, Listen & Save Data.

https://ytify.netlify.app

GNU General Public License v3.0

145 stars 48 forks source link

Improving Desktop View #93

Closed n-ce closed 1 year ago

n-ce commented 1 year ago

download (2) Screenshot from pagespeed.web.dev

Since i do not have a desktop computer i have not been able to successfully render a proper view on the desktop despite my several attempts, it always looks underfunctioning. It is my request to interested developers who want to work on this to improve the web app experience on desktop.

What requires changing?

The player container width should be equal to the data container.
The text on the data container should be large enough to fill it. Currently there is this white unused space which makes it look worse.
button labels should be readable.
and or anything the assigned developer thinks should change.

himanshukrmr commented 1 year ago

Hi @n-ce if someone is not working on this I like to try this.

himanshukrmr commented 1 year ago

@n-ce Thanks for assigning

himanshukrmr commented 1 year ago

Hi @n-ce after changing the desktop view is looking like this. If it is fine then I will raise a pr.

n-ce commented 1 year ago

@himanshukrmr go ahead and raise a pr, from there we will be making changes if needed.

NeeRaj-2401 commented 1 year ago

this is something seriously need to be improved,

IMO there is no need to show Full name of related streams, we could cut down the title and keep only important part my implementation for the same was ...

in that way, there is no need of overflow: scroll;

n-ce commented 1 year ago

okay, would you like to work on this?

i was also intending to add the duration data to that component.
also i had no idea that scrollbars were visible like that in my setup it looked clean.

NeeRaj-2401 commented 1 year ago

okay, would you like to work on this?

As my exams are going to start soon, i can't promise active development on that. But if i will get some free time, i will work on it for sure :)

NeeRaj-2401 commented 1 year ago

Hey @n-ce hope you r good, Just wanted to let you know that, i won't be able to work on this for atleast a month due to exams and all. Hope you understand :)

n-ce commented 1 year ago

Hey @n-ce hope you r good, Just wanted to let you know that, i won't be able to work on this for atleast a month due to exams and all. Hope you understand :)

@NeeRaj-2401 im doing good despite some physical troubles, and the break is completely fine, as it is not a functional problem it is not urgent.

n-ce commented 1 year ago

This will be now foreseen in #110