Closed himanshukrmr closed 1 year ago
Name | Link |
---|---|
Latest commit | 690e07649adcfb5243f91ac3d589f82fd0e5e5a4 |
Latest deploy log | https://app.netlify.com/sites/ytify/deploys/6422e46efbf09a0008e3b715 |
Deploy Preview | https://deploy-preview-99--ytify.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
- The player profiles is not centered
- On settings button click, the container is overflowing. The height of the player container should remain consistent.
ok fixing these issues @n-ce and what is player profile in this case?
- The player profiles is not centered
- On settings button click, the container is overflowing. The height of the player container should remain consistent.
ok fixing these issues @n-ce and what is player profile in this case?
also do you think it would be better if we move the input box to metadata container just below author+bitrate ?
Our end goal is to have a solid and consistent user interface across both mobile and desktop.
- The player profiles is not centered
- On settings button click, the container is overflowing. The height of the player container should remain consistent.
ok fixing these issues @n-ce and what is player profile in this case?
playerProfiles is another container inside #playerContainer, check the html. Also please keep verifying the mobile ui as you develop otherwise we might be breaking the ui altogether.
also do you think it would be better if we move the input box to metadata container just below author+bitrate ?
Our end goal is to have a solid and consistent user interface across both mobile and desktop.
yes, for input box it is a good idea actually by this we can also cover the white space which will come if some youtube video has a smaller headline. will check the mobile views.
Testing the new input position with some changes that were necessary, so far so good.
Testing the new input position with some changes that were necessary, so far so good.
ok, that's great if it's working fine. and now is it still overflowing after clicking on the settings button or that's also fixed?
Sorry, It took me way longer than it should have but I have just now commited the changes, but it seems there are conflicts. can you resolve the conflicts that are appearing? @himanshukrmr
done changes in the desktop and mobile view.