n8acl / aprsnotify

APRS Notification bot for various Social Media Networks
https://n8acl.github.io/aprsnotify
GNU General Public License v3.0
15 stars 3 forks source link

Added flask as req and fixed version var error #7

Closed igorrecioh closed 1 year ago

igorrecioh commented 1 year ago

Hi @n8acl ,

first of all thanks for this great work. I was trying it and some errors appeared. I'd like to contribute to your work with some ease improvements:

Kind regards,

Igor

n8acl commented 1 year ago

Hello Igor

While I appreciate the contribution, I will not be merging this change for two reasons:

1) the missing flask requirement is going to be added back in a. Release I am preparing. I am making some other changes to fix that part.

2) the version variable would be instantiated by the for loop. The version is pulled from the database above it and then instantiated within the for loop with the value from the database. If it errored then your database did not create correctly. Delete the database and try it again. Especially if you had the flask error after installation.

Thanks again.

Jeff

igorrecioh commented 1 year ago

Hi Jeff,

yes, it was failing the first time due to a db error and then the version variable error appeared. Good to know how to fix it, thanks a lot!