nabil-boag / angular-multimocks

Tools for managing mock data scenarios in AngularJS applications.
MIT License
35 stars 11 forks source link

Removes Bower #31

Closed paulreeve closed 8 years ago

paulreeve commented 8 years ago

Overview

Unlike most, I develop behind a corporate proxy which makes NPM just about bearable but Bower completely out of the question. Having inspected what libraries Bower was being used for, I realised NPM could fulfil all of these. This PR removes Bower from the equation completely which obviously helps me :smile: but also should simplify things slightly.

Details

All unit tests run and pass in Phantom and browsers:

INFO [PhantomJS 1.9.8 (Mac OS X 0.0.0)]: Connected on socket fwFKhGTNB3hshgt-WldZ with id 50528167
..............................
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 30 of 30 SUCCESS (0.029 secs / 0.049 secs)

..............................
Chrome 46.0.2490 (Mac OS X 10.7.5): Executed 30 of 30 SUCCESS (0.132 secs / 0.119 secs)
INFO [Firefox 13.0.0 (Mac OS X 10.7.0)]: Connected on socket htFpZITc4Nchg53BWtrs with id 5745251

..............................
Firefox 13.0.0 (Mac OS X 10.7.0): Executed 30 of 30 SUCCESS (0.109 secs / 0.098 secs)
TOTAL: 60 SUCCESS
nabil-boag commented 8 years ago

This looks good. Thanks for the PR.

nabil-boag commented 8 years ago

Merging this PR I realise we don't really need a lot of the dependencies we have so I removed them here:

https://github.com/wongatech/angular-multimocks/pull/32

paulreeve commented 8 years ago

Awesome. Thanks @nabil-boag

nabil-boag commented 8 years ago

@paulreeve I just realised that the README.md needs to be updated from your PR. It still mentions bower and bower_components.

paulreeve commented 8 years ago

ok i'll take a look.