naixsu / CROCPNG

MIT License
0 stars 0 forks source link

added key direction dependent dash #25

Closed adiRed08 closed 11 months ago

adiRed08 commented 11 months ago

dash works but behaves based on what key was pressed for movement. will fix the mouse dependent dashing soon

naixsu commented 11 months ago

@adiRed08 pls change the dash keybind into Dash. Also, there's no need to create a new scene for the Dash node since all you have as a child of that scene is a Timer. Remove it and just add the Dash node directly as a child of the Player.

As for the mouse direction, the current dash implementation is already good. It was an oversight on my part thinking that the players should dash towards the mouse. However, when running away from an enemy, for instance, I believe it's much better to dash according to the key inputs as opposed to the mouse position (as it would ram the player directly into the enemies).

Ping me in dc again once the changes have been made to this PR.