search

namecheap / node-vault-client

A Vault Client implemented in pure javascript for HashiCorp Vault
Apache License 2.0
22 stars 21 forks source link

Return Instance if instance already booted when calling vault.boot() function. #32

Closed ansukumari closed 6 months ago

ansukumari commented 7 months ago

The description of the boot function says that "Calling Vault.boot multiple times with the same name will return the same instance." but in the code it is throwing error when the instance is already booted. Changed the code and its respective test to return the instance instead of throwing error.

ansukumari commented 7 months ago

@blackrabbit99 can you please review this.

malderete commented 6 months ago

@vzholudev @b1ff , might be you can revire this?

b1ff commented 6 months ago

Hey @malderete thanks for a ping, will look into this shortly.

b1ff commented 6 months ago

Merged, thanks for a contribution, will publish a new version shortly to NPM

b1ff commented 6 months ago

v1.0.1 is available in NPM

malderete commented 6 months ago

@b1ff awesome news, thanks for the quick response! 😄