nand2mario / snestang

Super Nintendo Entertainment System for Tang FPGA boards
GNU General Public License v3.0
166 stars 17 forks source link

sound is "hoarse" in Tang Nano 20k #16

Open cyberwisk opened 2 months ago

cyberwisk commented 2 months ago

First of all, congratulations on your incredible work... Since the first version for the Tang nano 20k I noticed that the sound is "hoarse" as if the input volume was saturated, I thought it was my Tang nano 20k unit, I bought another one and the same problem happens, is it a problem or does it exist? Is there any procedure I should do to make the sound crystal clear like the original?

rvkasper commented 2 months ago

First of all, congratulations on your incredible work... Since the first version for the Tang nano 20k I noticed that the sound is "hoarse" as if the input volume was saturated, I thought it was my Tang nano 20k unit, I bought another one and the same problem happens, is it a problem or does it exist? Is there any procedure I should do to make the sound crystal clear like the original?

Same on my primer 25k. Let us know if submitting some recorded footage might help

cyberwisk commented 2 months ago

https://photos.app.goo.gl/qYNaMpiY2VKNU41p6

nand2mario commented 2 months ago

Thanks for the footage. I'll investigate this.

nand2mario commented 1 month ago

Could you try this snestang_audiofix.zip to see if it is fixed?

The issue was that some samples were missing due to how the video synchronization works. This made sure sound is not impacted by the synchronization.

radiance28 commented 1 month ago

I compiled for Primer25k, the sound vibrates but much lessб but some crackling remained with the most high-frequency sounds of music, especially audible in Super Mario World on splash screen. I also noticed the periodic disconnection of some sound channels, sometimes the music has many voices, sometimes less.

https://photos.app.goo.gl/fTKYFZZVsAXFsrLa9

The camera doesn't pick it up well, but you can also hear it when the music volume changes

nand2mario commented 1 month ago

Interesting. I've just run super mario world for 30 mins without problem.

Let me see if I can reproduce.

radiance28 commented 1 month ago

https://photos.app.goo.gl/njjKfwjsxrKNirXo9

On the map you can hear on high-frequency sounds how it trembles a little

Also heard well on Konami splash

https://photos.app.goo.gl/ABCZGpgBhG9vuxMQ9

nand2mario commented 1 month ago

https://photos.app.goo.gl/njjKfwjsxrKNirXo9

On the map you can hear on high-frequency sounds how it trembles a little

Also heard well on Konami splash

https://photos.app.goo.gl/ABCZGpgBhG9vuxMQ9

Could you try the binary I attached? I want to make sure it isn't due to different building env.

radiance28 commented 1 month ago

With your version from the archive everything is the same, a slight crackle at high sounds and a slight trembling

nand2mario commented 1 month ago

So there's improvement and still some issues. I'll release this for now and we can solve the remaining quality issue later.