search

nanite / Simple-Discord-Rich-Presence

Simple Discord Rich Presence
13 stars 7 forks source link

Doesn't work with "The Midnight" mod #1

Closed ghost closed 5 years ago

ghost commented 5 years ago

https://github.com/Cryptic-Mushroom/The-Midnight/issues/280

Gegy commented 5 years ago

I believe the lookup here is what is causing the issue: https://github.com/Sunekaer/Simple-Discord-Rich-Presence/blob/9c977e3c02a5f33866d578154d63c78e5caf2b82/src/main/java/com/sunekaer/mods/sdrp/discord/DiscordRichPresence.java#L61 If the dimension type isn't in the map, it'll call setState with a null value causing the NPE

Sunekaer commented 5 years ago

I can load midnight and sdrp together just fine and enter midnight dim

Sunekaer commented 5 years ago

logs of this not working? please use some paste bin site

Gegy commented 5 years ago

See the referenced issue's latest.log. I think it works fine in an isolated context but with more mods it breaks things

Sunekaer commented 5 years ago

Please paste it via https://paste.feed-the-beast.com, I have a policy of not downloading files I don't trust

Sunekaer commented 5 years ago

fix uploaded to curseforge